Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restrict commission setting to prevent arbitrary storage writing #1117

Merged
merged 2 commits into from
Jul 3, 2023
Merged

fix: restrict commission setting to prevent arbitrary storage writing #1117

merged 2 commits into from
Jul 3, 2023

Conversation

sander2
Copy link
Member

@sander2 sander2 commented Jul 3, 2023

No description provided.

gregdhill
gregdhill previously approved these changes Jul 3, 2023
View reviewed changes
@sander2 sander2 force-pushed the fix/prevent-arbitrary-commission branch 5 times, most recently from 563ca30 to 1826515 Compare July 3, 2023 18:29
@sander2 sander2 force-pushed the fix/prevent-arbitrary-commission branch from 1826515 to 8db2967 Compare July 3, 2023 18:34
@gregdhill gregdhill merged commit 3647221 into interlay:master Jul 3, 2023
2 checks passed
@gregdhill
Copy link
Member

When nomination is enabled set_commission could still be abused to clutter storage but since it is disabled on Kintsugi and Interlay this should suffice for now. We anyway plan to refactor the nomination code and more generally address storage deposits as noted here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregdhill gregdhill gregdhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sander2 @gregdhill