fork pallet-democracy and refactor for optimistic governance #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
feat/democracy-pallet
branch
2 times, most recently
from
0758266
to
f3cd3fc
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
feat/democracy-pallet
branch
from
f3cd3fc
to
5059bdd
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
feat/democracy-pallet
branch
from
523bb7a
to
8524e78
Compare
sander2
reviewed
Nov 23, 2021
| /// weighted according to this value with no refund. | ||
| /// | ||
| /// Weight: `O(S)` where S is the number of seconds a proposal already has. | ||
| #[pallet::weight(T::WeightInfo::second(*seconds_upper_bound))] |
There was a problem hiding this comment.
This is quite an unfortunate effect of storing the deposits in a vec. Since this is paritys code I'll assume this is for a good reason, but I haven't come across it yet
| index: ReferendumIndex, | ||
| status: ReferendumStatus<T::BlockNumber, T::Hash, BalanceOf<T>>, | ||
| ) -> Result<bool, DispatchError> { | ||
| let total_issuance = T::Currency::total_issuance(); |
There was a problem hiding this comment.
Not sure how this exactly will work if voting power decreases over time
There was a problem hiding this comment.
Good point, when I integrate the escrow pallet it will probably have to dynamically calculate the tally from the current block height.
| mut n1: T, | ||
| mut d1: T, | ||
| mut n2: T, | ||
| mut d2: T, |
There was a problem hiding this comment.
Maybe we should check if d1 and d2 are non-zero here, and return an option/result
sander2
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forks the Substrate democracy pallet in order to implement optimistic governance by default.