Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enums exposed over RPC should use camelCase #620

Merged
merged 1 commit into from Jul 28, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions primitives/src/lib.rs
Expand Up @@ -93,6 +93,7 @@ pub mod issue {

#[derive(Encode, Decode, Clone, PartialEq, TypeInfo, MaxEncodedLen)]
#[cfg_attr(feature = "std", derive(Debug, Serialize, Deserialize))]
#[cfg_attr(feature = "std", serde(rename_all = "camelCase"))]
pub enum IssueRequestStatus {
/// opened, but not yet executed or cancelled
Pending,
Expand Down Expand Up @@ -167,6 +168,7 @@ pub mod redeem {

#[derive(Encode, Decode, Clone, Eq, PartialEq, TypeInfo, MaxEncodedLen)]
#[cfg_attr(feature = "std", derive(Debug, Serialize, Deserialize))]
#[cfg_attr(feature = "std", serde(rename_all = "camelCase"))]
pub enum RedeemRequestStatus {
/// opened, but not yet executed or cancelled
Pending,
Expand Down Expand Up @@ -271,6 +273,7 @@ pub mod replace {

#[derive(Encode, Decode, Clone, PartialEq, TypeInfo, MaxEncodedLen)]
#[cfg_attr(feature = "std", derive(Debug, Serialize, Deserialize, Eq))]
#[cfg_attr(feature = "std", serde(rename_all = "camelCase"))]
pub enum ReplaceRequestStatus {
/// accepted, but not yet executed or cancelled
Pending,
Expand Down Expand Up @@ -330,6 +333,8 @@ pub mod oracle {
use super::*;

#[derive(Encode, Decode, Clone, Eq, PartialEq, Debug, TypeInfo, MaxEncodedLen)]
#[cfg_attr(feature = "std", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "std", serde(rename_all = "camelCase"))]
pub enum Key {
ExchangeRate(CurrencyId),
FeeEstimation,
Expand Down Expand Up @@ -489,6 +494,7 @@ create_currency_id! {

#[derive(Encode, Decode, Eq, Hash, PartialEq, Copy, Clone, RuntimeDebug, PartialOrd, Ord, TypeInfo, MaxEncodedLen)]
#[cfg_attr(feature = "std", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "std", serde(rename_all = "camelCase"))]
pub enum CurrencyId {
Token(TokenSymbol),
ForeignAsset(ForeignAssetId),
Expand Down