Handle leftover amounts on the engine side #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
force-pushed
the
engine-handle-leftovers
branch
from
07f00b6
to
e3f868d
Compare
emschwartz
approved these changes
Sep 28, 2019
| error!("Exceeded max retries when notifying connector about account {:?} for amount {:?} and transaction hash {:?}. Please check your API.", account_id_clone, amount_clone, tx_hash) | ||
| }) | ||
| .and_then(move |ret| { | ||
| trace!("Accounting system responded with {:?}", ret); |
There was a problem hiding this comment.
We should log a warning or error if they respond with something other than the amount we sent
There was a problem hiding this comment.
interledger/rfcs#536 (review) I do not think that the accounting system should be required to return an amount, since it will track leftovers internally
crates/interledger-settlement-engines/src/stores/redis_store_common.rs
Outdated
Show resolved
Hide resolved
gakonst
force-pushed
the
engine-handle-leftovers
branch
from
e628790
to
fe68b9d
Compare
gakonst
force-pushed
the
connector-handle-leftovers
branch
2 times, most recently
from
41b8ba6
to
02a9718
Compare
We implemented FromRedisValue for AmountWithScale. lrange fetches the AmountWithScale as a list and cannot differentiate each tuple from another, hence we have to perform the summation in the deserialization method
We assume that the connector is able to handle any potential precision loss due to the engine sending an amount with higher granularity than the connector can handle
gakonst
force-pushed
the
engine-handle-leftovers
branch
from
fe68b9d
to
f5c7b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #342