Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle leftover amounts on the engine side #344

Merged
merged 8 commits into from
Oct 4, 2019
Merged

Handle leftover amounts on the engine side #344

merged 8 commits into from
Oct 4, 2019

Commits on Oct 4, 2019

  1. feat(redis): Load and set leftovers properly as lists of strings

    @gakonst
    gakonst committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    b1cff81 View commit details
    Browse the repository at this point in the history

  2. chore: address review comments 

    We implemented FromRedisValue for AmountWithScale. lrange fetches the AmountWithScale as a list and cannot differentiate each tuple from another, hence we have to perform the summation in the deserialization method
    @gakonst
    gakonst committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    c425ed6 View commit details
    Browse the repository at this point in the history

  3. fix(eth-engine): Do not mutate change based on the connector's response 

    We assume that the connector is able to handle any potential precision loss due to the engine sending an amount with higher granularity than the connector can handle
    @gakonst
    gakonst committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    f7d88bd View commit details
    Browse the repository at this point in the history

  4. feat(engines): Copy the LeftoversStore implementation from the Redis … 

    …Store
    @gakonst
    gakonst committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    2153007 View commit details
    Browse the repository at this point in the history

  5. fix(tests): Update test helpers to use new LeftoversStore implementation

    @gakonst
    gakonst committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    6936ee7 View commit details
    Browse the repository at this point in the history

  6. test(eth-engine): add failing test where connector sends tiny amounts… 

    … to the engine
    @gakonst
    gakonst committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    dc81957 View commit details
    Browse the repository at this point in the history

  7. feat(eth-engine): Save leftover amounts if the connector sent us a ti… 

    …ny value
    @gakonst
    gakonst committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    43112a3 View commit details
    Browse the repository at this point in the history

  8. chore(engine-store): remove pipes

    @gakonst
    gakonst committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    f5c7b9f View commit details
    Browse the repository at this point in the history