chore(*): clippy 1.51 lints #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
koivunej
commented
Mar 25, 2021
koivunej
commented
- 2021 edition lints re: panic
- 1.51 redundant_slicing
- needless_question_mark
|
Celebrating the 1.51 release. These changes will hike the minimum supported rust version to 1.51 because of the removed now redundant slicing. It seems that the readme is already out of date as the minimum with our dependencies (the |
- 2021 edition lints re: panic - 1.51 redundant_slicing - needless_question_mark Signed-off-by: Joonas Koivunen <joonas.koivunen@gmail.com>
this had already fallen out of updating with some dependency updates prompted by cargo audit when it was raised to 1.46 for `if` inside `const fn`. in #696 the minimum version became 1.51. since this codebase depends on a lot of the cryptography infrastructure likely to be updated in the near future due to const generics availability, it is not worth pursuing any older MSRV. Signed-off-by: Joonas Koivunen <joonas.koivunen@gmail.com>
|
Added the removal of MSRV 1.45 in the latest commit. This isn't supposed to be a project wide decision, but I assume it had to be raised already for the I wouldn't want to block merging this PR on the README change as it is just updating the README to match the reality which has been for quite some time. |
pradovic
approved these changes
Mar 26, 2021
|
Enough time has passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.