Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow createWalletAddress mutation to take in additional properties #2739

Closed
5 tasks done
Tracked by #2730
mkurapov opened this issue May 22, 2024 · 0 comments · Fixed by #2752
Closed
5 tasks done
Tracked by #2730

Allow createWalletAddress mutation to take in additional properties #2739

mkurapov opened this issue May 22, 2024 · 0 comments · Fixed by #2752
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented May 22, 2024

Context

During wallet address creation, we want to let the ASE allow to add additional properties to be associated with the wallet address.

We need to update the createWalletAddress mutation input to take in additionalProperties.
These properties would be optionally visible when requesting a wallet address through Open Payments. The input is an optional array of objects with key & value and visibleInOpenPayments (suggested name), a flag that enables or disables this field from appearing in Open Payments Wallet Address lookup.

Tasks

  • Update createWalletAddress mutation input
  • Store these fields in a new table with structure: walletAddressId: FK fieldKey: string fieldValue: string visibleInOpenPayments: bool, createdAt: Date, updatedAt: Date)
  • Expose these new fields when fetching wallet address via Open Payments (making sure to show only fields that are indeed enabled for visibility for Open Payments)
  • Expose these new fields when fetching wallet address via the Admin API
  • Update the documentation

PR

#2752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants