Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updateWalletAddress mutation to take in additional properties #2740

Closed
3 tasks done
Tracked by #2730
mkurapov opened this issue May 22, 2024 · 0 comments · Fixed by #2769
Closed
3 tasks done
Tracked by #2730

Allow updateWalletAddress mutation to take in additional properties #2740

mkurapov opened this issue May 22, 2024 · 0 comments · Fixed by #2769
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented May 22, 2024

Context

Similar to wallet address creation in #2739, we want to let the ASE allow updating additional properties to be associated with the wallet address.

We need to update the updateWalletAddress mutation input to take in additionalProperties.
These properties are the same as the createWalletAddress input: an optional array of objects with key & value and visibleInOpenPayments.

Tasks

  • Update updateWalletAddress mutation input to take in additional params
  • Update these new fields in the new wallet address table, hard deleting keys that are no longer used
  • Update Documentation, including update behavior (overrides entire additionalFields on each update)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants