Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend)!: update env variables #2732

Closed
wants to merge 6 commits into from
Closed

Conversation

golobitch
Copy link
Collaborator

@golobitch golobitch commented May 21, 2024

Changes proposed in this pull request

  • Change default env variables values
  • Rename one environment variable
  • Update localenv
  • Update integration tests
  • Update documentation

Context

fixes #2684

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@golobitch golobitch self-assigned this May 21, 2024
@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic labels May 21, 2024
Copy link

netlify bot commented May 21, 2024

Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 01f5b18
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66559fbbdc983d00084e38b6
😎 Deploy Preview https://deploy-preview-2732--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: tests Testing related label May 22, 2024
@@ -32,6 +33,7 @@ services:
AUTH_SERVER_INTROSPECTION_URL: http://cloud-nine-wallet-test-auth:3107
AUTH_SERVER_GRANT_URL: http://cloud-nine-wallet-test-auth:3106
ILP_ADDRESS: test.cloud-nine-wallet-test
ILP_CONNECTOR_ADDRESS: http://127.0.0.1:3102
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be?

Suggested change
ILP_CONNECTOR_ADDRESS: http://127.0.0.1:3102
ILP_CONNECTOR_ADDRESS: http://host.docker.internal:3102

golobitch and others added 3 commits May 28, 2024 11:09
* feat(auth)!: remove default values for cookie key and identity server secret

* feat(auth)!: rename auth server domain to auth server url

* test(integration): update env

* feat(localenv): update auth env

* feat(localenv): update identity server url

* test(integration): update identity server url

* feat(auth)!: rename identity server domain to server url

* docs(integration): update deployment env variables

* fix(documentation): auth env grammatical error

Co-authored-by: Nathan Lie <lie4nathan@gmail.com>

---------

Co-authored-by: Nathan Lie <lie4nathan@gmail.com>
* feat(2712): make use of backend accounting service.

* feat(2712): make use of backend accounting service.

* feat(2712): introduce BasicAccountingService.

* feat(2712): formatting.

* feat(2712): formatting.

* feat(2712): remove the BaseAccountingService.

* feat(2712): address warnings.

* feat(2712): review comments.
@github-actions github-actions bot added pkg: auth Changes in the GNAP auth package. pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation labels May 28, 2024
@golobitch golobitch closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation type: source Changes business logic type: tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backend] update env vars and remove defaults
3 participants