-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ping Protocol #516
Ping Protocol #516
Conversation
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for documenting the protocol.
I left some comments.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat. |
Bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, just realized I never submitted this comment!
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that's missing from here is a section on the security of this protocol. I would look at it from the perspective of avoiding DoS attacks as well as how to use the information you get back from this protocol. Because this isn't authenticated at all, any connector along the path can preemptively return a fulfill or reject pretending to be the node you're attempting to ping.
…ional-flow. Signed-off-by: Taiga Nakayama <dora@dora-gt.jp>
Add images for the unidirectional-flow and bidirectional-flow.
Co-Authored-By: Evan Schwartz <evan@ripple.com>
Co-Authored-By: Evan Schwartz <evan@ripple.com>
Co-Authored-By: Evan Schwartz <evan@ripple.com>
Co-Authored-By: Evan Schwartz <evan@ripple.com>
* Reword various paragraphs with new suggested terminology. * Move mode-specific portions to the appropriate sections. * Improve Implementation Considerations. * Add link to OER encoding notes. * Fix ordered-list numbering Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat. |
Following discussion in the ILP Forum here, this PR introduces the Ping Protocol, which specifies a mechanism for Interledger nodes to test uptime and fulfill/reject response-time for a particular payment path, from the perspective of a payment sender.