Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping Protocol #516

Closed
wants to merge 15 commits into from
Closed

Ping Protocol #516

wants to merge 15 commits into from

Conversation

sappenin
Copy link
Contributor

@sappenin sappenin commented Mar 1, 2019

Following discussion in the ILP Forum here, this PR introduces the Ping Protocol, which specifies a mechanism for Interledger nodes to test uptime and fulfill/reject response-time for a particular payment path, from the perspective of a payment sender.

Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
Copy link
Member

@dora-gt dora-gt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting the protocol.
I left some comments.

0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
Remove errant article and change spelling.
@stale
Copy link

stale bot commented Apr 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.

@stale stale bot added the wontfix label Apr 5, 2019
@sappenin
Copy link
Contributor Author

Bump

Copy link
Member

@emschwartz emschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, just realized I never submitted this comment!

0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
adrianhopebailie and others added 3 commits May 13, 2019 10:16
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
Copy link
Member

@emschwartz emschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that's missing from here is a section on the security of this protocol. I would look at it from the perspective of avoiding DoS attacks as well as how to use the information you get back from this protocol. Because this isn't authenticated at all, any connector along the path can preemptively return a fulfill or reject pretending to be the node you're attempting to ping.

0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
0000-ilp-ping-protocol/0000-ilp-ping-protocol.md Outdated Show resolved Hide resolved
…ional-flow.

Signed-off-by: Taiga Nakayama <dora@dora-gt.jp>
sappenin and others added 8 commits June 3, 2019 19:33
Add images for the unidirectional-flow and bidirectional-flow.
Co-Authored-By: Evan Schwartz <evan@ripple.com>
Co-Authored-By: Evan Schwartz <evan@ripple.com>
Co-Authored-By: Evan Schwartz <evan@ripple.com>
Co-Authored-By: Evan Schwartz <evan@ripple.com>
* Reword various paragraphs with new suggested terminology.
* Move mode-specific portions to the appropriate sections.
* Improve Implementation Considerations.
* Add link to OER encoding notes.
* Fix ordered-list numbering

Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
@stale
Copy link

stale bot commented Jul 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.

@stale stale bot added the wontfix label Jul 5, 2019
@stale stale bot closed this Jul 12, 2019
@sappenin sappenin reopened this Jul 16, 2019
@stale stale bot removed the wontfix label Jul 16, 2019
@sharafian sharafian removed their request for review July 30, 2019 21:11
@stale
Copy link

stale bot commented Aug 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants