durable stream sender API #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new API /accounts/{accountId}/payments
new packet switch filter and link filter to capture and aggregate stream payments
removed TrackingStreamReceiver because it's no longer necessary now that aggregation is handled by filters
added delivered_amount/code/scale to StreamPayments table
add service to orchestrate payments using SimpleStreamSender
new LocalPacketSwitchLink that for local routing to the packet switch
Signed-off-by: nhartner <nhartner@gmail.com>
sappenin
requested changes
May 12, 2020
connector-server/src/test/java/org/interledger/connector/server/client/ConnectorUserClient.java
Outdated
Show resolved
Hide resolved
.../java/org/interledger/connector/server/spring/controllers/pay/StreamPaymentEndpointTest.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/interledger/connector/links/filters/OutgoingStreamPaymentLinkFilter.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/interledger/connector/links/filters/OutgoingStreamPaymentLinkFilter.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/interledger/connector/links/filters/OutgoingStreamPaymentLinkFilter.java
Outdated
Show resolved
Hide resolved
...or-service-impl/src/main/java/org/interledger/connector/localsend/LocalPacketSwitchLink.java
Outdated
Show resolved
Hide resolved
...ce-impl/src/main/java/org/interledger/connector/localsend/LocalPacketSwitchLinkSettings.java
Show resolved
Hide resolved
...ce-impl/src/main/java/org/interledger/connector/localsend/LocalPacketSwitchLinkSettings.java
Outdated
Show resolved
Hide resolved
...vice-impl/src/main/java/org/interledger/connector/payments/SimpleExchangeRateCalculator.java
Show resolved
Hide resolved
connector-service-impl/src/main/java/org/interledger/connector/stream/StreamPacketUtils.java
Show resolved
Hide resolved
sappenin
reviewed
May 12, 2020
...or-service-impl/src/main/java/org/interledger/connector/localsend/LocalPacketSwitchLink.java
Outdated
Show resolved
Hide resolved
…ill and remote-send/remote-fulfill fix bug with decrypting stream packet on local-send/remote-fulfill fix breaking tests due to eager initialization of all controllers Signed-off-by: nhartner <nhartner@gmail.com>
- remove duplicate method that's a copy-paste artifact - javadoc - test coverage for StreamPacketUtils - try/catch around fulfillment aggregation to ensure fulfillment is still returned Signed-off-by: nhartner <nhartner@gmail.com>
…it is needed by fulfillment aggregation to decrypt stream packets Signed-off-by: nhartner <nhartner@gmail.com>
…data that we want to know about. Signed-off-by: nhartner <nhartner@gmail.com>
Signed-off-by: nhartner <nhartner@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
============================================
- Coverage 67.93% 66.29% -1.64%
- Complexity 1321 1342 +21
============================================
Files 323 336 +13
Lines 6399 6536 +137
Branches 262 263 +1
============================================
- Hits 4347 4333 -14
- Misses 1930 2089 +159
+ Partials 122 114 -8
Continue to review full report at Codecov.
|
Signed-off-by: nhartner <nhartner@gmail.com>
sappenin
approved these changes
May 13, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new API /accounts/{accountId}/payments
new packet switch filter and link filter to capture and aggregate stream payments
removed TrackingStreamReceiver because it's no longer necessary now that aggregation is handled by filters
added delivered_amount/code/scale to StreamPayments table
add service to orchestrate payments using SimpleStreamSender
new LocalPacketSwitchLink that for local routing to the packet switch
Signed-off-by: nhartner nhartner@gmail.com