feat: BREAKING Use RejectionMessage for ILP Errors #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 83.25% 84.22% +0.97%
==========================================
Files 33 33
Lines 1051 1065 +14
Branches 158 161 +3
==========================================
+ Hits 875 897 +22
+ Misses 176 168 -8
Continue to review full report at Codecov.
|
emschwartz
approved these changes
Feb 17, 2017
emschwartz
reviewed
Feb 17, 2017
| @@ -0,0 +1,12 @@ | |||
| 'use strict' | |||
|
|
|||
| const BaseError = require('five-bells-shared').BaseError | |||
There was a problem hiding this comment.
Rather than extending all of them directly in the code, it would probably be better to have an ILP error module as suggested in interledger-deprecated/ilp-plugin-bells#83
sentientwaffle
added a commit
that referenced
this pull request
Mar 9, 2017
PR includes #308 Depends on five-bells-shared, ilp-core, ilp-plugin-bells, ilp-routing
sentientwaffle
added a commit
that referenced
this pull request
Mar 9, 2017
PR includes #308 Depends on five-bells-shared, ilp-core, ilp-plugin-bells, ilp-routing
|
Superseded by #322 |
sentientwaffle
added a commit
that referenced
this pull request
Mar 10, 2017
PR includes #308 Depends on five-bells-shared, ilp-core, ilp-plugin-bells, ilp-routing Rename `IlpHeader` → `IlpPayment`
sentientwaffle
added a commit
that referenced
this pull request
Mar 13, 2017
PR includes #308 Depends on five-bells-shared, ilp-core, ilp-plugin-bells, ilp-routing Rename `IlpHeader` → `IlpPayment`
sentientwaffle
added a commit
that referenced
this pull request
Mar 13, 2017
PR includes #308 Depends on five-bells-shared, ilp-core, ilp-plugin-bells, ilp-routing Rename `IlpHeader` → `IlpPayment`
justmoon
pushed a commit
that referenced
this pull request
Mar 15, 2017
PR includes #308 Depends on five-bells-shared, ilp-core, ilp-plugin-bells, ilp-routing Rename `IlpHeader` → `IlpPayment`
justmoon
pushed a commit
that referenced
this pull request
Mar 16, 2017
PR includes #308 Depends on five-bells-shared, ilp-core, ilp-plugin-bells, ilp-routing Rename `IlpHeader` → `IlpPayment`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on interledger-deprecated/ilp-plugin-bells#98, interledger-deprecated/five-bells-shared#179, interledgerjs/five-bells-integration-test#63