Remove invalid draw options, fixing geneExpressionAtlas displayers #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fail It's really only backgroundColor that causes the error, but hAxis and legend are also invalid and don't seem to have an effect.
|
tested, merging to dev (could be useful soon) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
A fix for the broken humanmine expression viewers on the gene report page mentioned here: #2282
#2283 only fixed the flymine list widgets; this PR fixes the separate problem causing the humanmine displayers to fail.
It's really only backgroundColor that causes the error, but hAxis and legend are also invalid and don't seem to have an effect (according to https://developers.google.com/chart/interactive/docs/gallery/barchart).
I didn't look into reimplementing the background color with its correct property as the displayer seems to look fine as it is.
Testing
I only tested this fix with each displayer isolated. You'll need to update the jsp files in a humanmine to test properly.
Checklist
Before your pull request can be approved, be sure to check all boxes: