use ember-auto-import

[4www]

Start using https://github.com/ef4/ember-auto-import

instead of the traditional import {someThing} from npm:some-thing

[4www]

I'm not sure what's going on but locally i've got errors.

ypeError: Array.prototype.slice.apply(...).filter(...)[0] is undefined
app.js%20line%2065834%20%3E%20eval:4:1
<anonymous>
webpack://__ember_auto_import__/./tmp/ember_auto_import_webpack-staging_dir-WEF1Z69M.tmp/app.js?:4:1
./tmp/ember_auto_import_webpack-staging_dir-WEF1Z69M.tmp/app.js
app.js:165
__webpack_require__
app.js:80
checkDeferredModules
app.js:47
webpackJsonpCallback
app.js:34
<anonymous>
app.js:170

Investigating

[oskarrough]

It's because of ember-cli-concat. ember-auto-import expects the DOM to include vendor+app scripts, which are currently commented out.

Try putting them back in and remove {{concat-js}}

https://github.com/internet4000/radio4000/blob/master/app/index.html#L28-L30

[4www]

Ty! Will try this.
How did you figure it out? Could not find out

[oskarrough]

Took some (much) time and trial and error……

If you expand the error when you start the server, it says

app.js:5 Uncaught TypeError: Cannot read property 'src' of undefined
    at eval (app.js:5)

and that line is:

if (typeof document !== 'undefined') {
__webpack_require__.p = Array.prototype.slice.apply(document.querySelectorAll('script'))
  .filter(function(s){ return /\/vendor/.test(s.src); })[0]
  .src.replace(/\/vendor.*/, '/');

and then I remembered that we don't have vendor.js in our index.html. Tried adding it back and then it worked!

Opened an issue here embroider-build/ember-auto-import#87

In any case, I'd say we skip concat for our scripts. Since we have HTTP2 with Netlify it should be ok (better even?) with more files, smaller file sizes.

[oskarrough]

Cool! @hugurp mind keeping the radio4000.js script async? And remove ember-browserify.

[oskarrough]

mind keeping this one as async?

[4www]

why keeping?
just the one on line 28?

[oskarrough]

Yes, just the second. So we're sure it loads after the first.

It should be faster when async, so it doesn't block rendering.