Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webapp start_url in manifest json, from index.html to / #289

Merged
merged 1 commit into from
Dec 30, 2018
Merged

fix: webapp start_url in manifest json, from index.html to / #289

merged 1 commit into from
Dec 30, 2018

Conversation

4www
Copy link
Contributor

@4www 4www commented Dec 23, 2018 •
edited

Saving r4 as bookmark to desktop (aka making r4 a webapp in practice) does not work, as it seems it is saving r4.com/index.html.

Trying to make start_url to /

@4www 4www requested a review from oskarrough December 23, 2018 14:05
@4www
Copy link
Contributor Author

4www commented Dec 25, 2018

Oupsi, I'm maybe mistaking.

Facebook's create-react-app seems to be using . instead of /.

https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/public/manifest.json#L11

oskarrough
oskarrough approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@oskarrough oskarrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. I should think / is just as fine, at least for ember apps.

@oskarrough oskarrough merged commit 872d7f3 into master Dec 30, 2018
@oskarrough oskarrough deleted the fix/web-app-start-url branch January 9, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarrough oskarrough oskarrough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@4www @oskarrough