Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and configure service worker #290

Merged
merged 5 commits into from
Jan 7, 2019
Merged

Add and configure service worker #290

merged 5 commits into from
Jan 7, 2019

Conversation

oskarrough
Copy link
Member

I've had trouble with service workers before. They make development harder. But they also make the site quite a bit faster and able to render something when offline.

But ember-service-worker recently added a feature to handle caching http://ember-service-worker.com/documentation/configuration/#versioning. So every time we yarn build, a new filename is generated and caching shouldn't be an issue. Let's see?

@oskarrough oskarrough requested a review from 4www January 6, 2019 13:07
@oskarrough oskarrough changed the title WIP Add and configure service worker Add and configure service worker Jan 6, 2019
@4www
Copy link
Contributor

4www commented Jan 7, 2019

Neetos!

Feedback:

  • "no internet" message disappear when dummy app is removed

Feature idea:

  • when offline, "file input" to select a folder with the offline tracks (and would work exactly like r4)

@oskarrough
Copy link
Member Author

Right about the offline message. It only happens in production. In development the offline message stays there, meaning the app doesn't render. Don't know why.

Can test with ember serve -prod. Gotta find a solution for that before merging.

@oskarrough oskarrough self-assigned this Jan 7, 2019
@4www
Copy link
Contributor

4www commented Jan 7, 2019

It's perfect, let's go with that and make it a component when ready for some offline support.

@oskarrough oskarrough merged commit 7a0e2b7 into master Jan 7, 2019
@oskarrough oskarrough deleted the feat/service-worker branch January 9, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants