-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better fullscreen + dock player mode #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docked mode looks pretty with the background. Also great having proper fullscreen.
When you tap the button to dock the player, I'm not sure how to exit it again. If you click the same button again, it moves player to the "sidebar-mode" but stays docked? Only way is to use the browser's back button or the menu? Maybe this is ok.
When in fullscreen, and you tap "docked", you end up in a mode without background. Hide "docked" button when in fullscreen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when in docked, I can tap left and right to go back. neat! can we also have it work on top and below?
// position bg image | ||
background-size: cover; | ||
background-position: center; | ||
filter: blur(1px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more blur? 1px makes it seem like it's just a bad quality image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could also load a bigger image here, if we want?
When you land on https://deploy-preview-394--radio4000.netlify.com/radio-island-breeze/player, it shows a button instead of the player. Why not have the player immediately? |
When I tap "escape" in fullscreen, I get this error:
|
It shows the channel cover image in fullscreen, a play button, then the player displayed in the DOM (static, docked). The UX should favor movements between modes.