Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fullscreen + dock player mode #394

Merged
merged 17 commits into from
Aug 15, 2019
Merged

Better fullscreen + dock player mode #394

merged 17 commits into from
Aug 15, 2019

Conversation

4www
Copy link
Contributor

@4www 4www commented Aug 1, 2019

  • improve fullscreen mode by using the browser's fullscreen. It allows us to have on mobile and desktop a better experience since the browser's URL bar is hidden, and only the radio4000-player (Aside--right, to have the r4-cms layout controls) is displayed fullscreen.
  • add a new mode, docked, at /channel/player.
    It shows the channel cover image in fullscreen, a play button, then the player displayed in the DOM (static, docked). The UX should favor movements between modes.

@4www 4www requested a review from oskarrough August 1, 2019 16:24
Copy link
Member

@oskarrough oskarrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docked mode looks pretty with the background. Also great having proper fullscreen.

When you tap the button to dock the player, I'm not sure how to exit it again. If you click the same button again, it moves player to the "sidebar-mode" but stays docked? Only way is to use the browser's back button or the menu? Maybe this is ok.

When in fullscreen, and you tap "docked", you end up in a mode without background. Hide "docked" button when in fullscreen?

Copy link
Member

@oskarrough oskarrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when in docked, I can tap left and right to go back. neat! can we also have it work on top and below?

// position bg image
background-size: cover;
background-position: center;
filter: blur(1px);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more blur? 1px makes it seem like it's just a bad quality image.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also load a bigger image here, if we want?

@oskarrough
Copy link
Member

When you land on https://deploy-preview-394--radio4000.netlify.com/radio-island-breeze/player, it shows a button instead of the player. Why not have the player immediately?

@oskarrough
Copy link
Member

When I tap "escape" in fullscreen, I get this error:

radio4000-2a1de9342cad2f9255eb1720d34cb05f.js:466 Uncaught (in promise) TypeError: Document not active
    at n.exitFullscreen (radio4000-2a1de9342cad2f9255eb1720d34cb05f.js:466)
    at n.toggleNormalFormat (radio4000-2a1de9342cad2f9255eb1720d34cb05f.js:466)
    at n.toggleDockedFormat (radio4000-2a1de9342cad2f9255eb1720d34cb05f.js:466)
    at n.toggleDockedFormat (radio4000-2a1de9342cad2f9255eb1720d34cb05f.js:289)
    at n.send (vendor-b5275e113e0b5e284eb9f99b7b50fc55.js:2985)

@4www 4www merged commit fe1d5b0 into master Aug 15, 2019
@4www 4www deleted the feat/dock-player branch August 15, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants