Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding track from url query param #399

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Conversation

4www
Copy link
Contributor

@4www 4www commented Sep 4, 2019

User submitted issue by mail.

I think this should fix it

Guessing a bit on the problem's origin; it is the only place in the code we're using this method setupController.

What do you think?

@4www 4www requested a review from oskarrough September 4, 2019 19:35
@oskarrough
Copy link
Member

I tried parsedURL.searchParams.get('WRITE WHATEVER HERE') and it doesn't throw an error. So maybe it is something else?

@oskarrough oskarrough merged commit f15cf07 into master Sep 5, 2019
@oskarrough oskarrough deleted the fix/add-from-url branch October 13, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants