Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to disable the save channel settins btn if no change #401

Merged
merged 7 commits into from
Dec 8, 2020
Merged

Try to disable the save channel settins btn if no change #401

merged 7 commits into from
Dec 8, 2020

Conversation

4www
Copy link
Contributor

@4www 4www commented Sep 4, 2019

try to fix this #141

not sure why it is not working.

Seems that the computed property ignores the updates on the proxy object.

Any idea why?

@oskarrough
Copy link
Member

oops, that fix links wasn't supposed to be on this branch but master.

@oskarrough
Copy link
Member

You can't use the computed.empty on objects. It works for string and arrays, as far as I can see. So I tried with a manual check. Does it work for you, too?

43562d6

@oskarrough oskarrough changed the title WIP try to disable the save channel settins btn if no change Try to disable the save channel settins btn if no change Apr 21, 2020
@4www 4www changed the title Try to disable the save channel settins btn if no change WIP: Try to disable the save channel settins btn if no change Aug 26, 2020
@4www 4www changed the title WIP: Try to disable the save channel settins btn if no change Try to disable the save channel settins btn if no change Dec 8, 2020
@4www 4www merged commit ce529da into master Dec 8, 2020
@4www 4www deleted the fix/channel-settings-save branch December 8, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@4www @oskarrough @hugurp