Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /:channel/tags #405

Merged
merged 5 commits into from
Sep 14, 2019
Merged

add /:channel/tags #405

merged 5 commits into from
Sep 14, 2019

Conversation

4www
Copy link
Contributor

@4www 4www commented Sep 6, 2019

List all tags and order them by popularity, most occurrences first.

  • track model now have a computed property track.tags
  • add a /channel/tags route
  • list selected tags, those in the channel.body
  • list tracks with no tags, so it is easier to start editing

What we can think about in the future:

  • show how many tracks are in a tag; ex: house (200)
  • should the tags link display all tags on the tags page, or continue linking to /:channel/tracks?search=#tag
  • where to list all tracks without discogs
  • where to list all tracks with broken media links
  • how to mass edit multiple tracks at once, add tags. remove tags, clean things up
  • how to rename a tag; ex: rename #PM to #pm

@4www 4www requested a review from oskarrough September 6, 2019 11:39
@4www 4www changed the title add a basic tag route to start thinking about it add /channel/tags Sep 7, 2019
@4www 4www changed the title add /channel/tags add /:channel/tags Sep 7, 2019
@oskarrough
Copy link
Member

This is super cool!!

On the channel page, the /tags link only appears if you have hashtags in your channel.body, or how does it work?

https://deploy-preview-405--radio4000.netlify.com/oskar/ko002
https://deploy-preview-405--radio4000.netlify.com/oskar/tags

@4www 4www merged commit f1974a3 into master Sep 14, 2019
@4www 4www deleted the feat/channel-tags branch September 14, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants