basic latest featured #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4www
commented
Apr 2, 2020
| @@ -4,6 +4,10 @@ import ChannelsIndexRoute from 'radio4000/channels/index/route' | |||
|
|
|||
| export default ChannelsIndexRoute.extend({ | |||
There was a problem hiding this comment.
Here either:
- just a normal route
- or do not rewrite the model hook
There was a problem hiding this comment.
I vote 2, so it's not just "latest featured" but random like on the homepage. But both work of course :]
|
Huh, wondering since when is the about page showing all radios… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now on https://radio4000.com/about it is showing all radios.
Thinking this is simpler, but we're still extending ChannelsIndexRoute, where I override the model, so that is actually unneded.