Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ember-service-worker #500

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Remove ember-service-worker #500

merged 5 commits into from
Nov 24, 2021

Conversation

oskarrough
Copy link
Member

@oskarrough oskarrough commented Nov 23, 2021

I don't want to remove the service worker, but it is what seems to be the quickest fix for #499.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Nov 23, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e5c4a11
Status: ✅  Deploy successful!
Preview URL: https://9b18d5af.radio4000.pages.dev

View logs

@oskarrough
Copy link
Member Author

Did not solve the issue. Hard-refreshing always works, but normal F5 or cmd+r does not.

@oskarrough oskarrough changed the title Remove Netlify redirects file Remove ember-service-worker Nov 23, 2021
@4www
Copy link
Contributor

4www commented Nov 24, 2021

I don't see any issue with the radio4000.com live version on webkit browsers; but received many complain sms

@oskarrough oskarrough merged commit f687a53 into master Nov 24, 2021
@oskarrough
Copy link
Member Author

I see this

screen 2021-11-24 at 11 23 47@2x

if I hard-refresh, it works. But as soon as I refresh or visit in another tab, it breaks again.

Merging for now, then we can add our own PWA service-worker without any ember addons :)

@4www 4www deleted the fix/cloudflarepages branch November 24, 2021 12:58
@4www
Copy link
Contributor

4www commented Nov 24, 2021

nicely done, yep, let's simplify!

@4www
Copy link
Contributor

4www commented Nov 24, 2021

Maybe it was something like that https://love2dev.com/blog/how-to-uninstall-a-service-worker/

When i open in chromium, it works if I unregister the service worker, then works accross refreshes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants