Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Codecov % Correctness #121

Merged
merged 3 commits into from Jul 24, 2019
Merged

Testing Codecov % Correctness #121

merged 3 commits into from Jul 24, 2019

Conversation

imskr
Copy link
Contributor

@imskr imskr commented Jul 16, 2019

I'm testing codecov coverage % ratio

@imskr imskr marked this pull request as ready for review July 16, 2019 16:08
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #121 into master will decrease coverage by 91.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #121       +/-   ##
==========================================
- Coverage     100%   8.97%   -91.03%     
==========================================
  Files           1       1               
  Lines           1    1960     +1959     
  Branches        0     352      +352     
==========================================
+ Hits            1     176      +175     
- Misses          0    1434     +1434     
- Partials        0     350      +350
Impacted Files Coverage Δ
BookReader/BookReader.js 8.97% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51ba03b...8e7af0f. Read the comment docs.

@imskr
Copy link
Contributor Author

imskr commented Jul 18, 2019

@jbuckner @mekarpeles I have fixed the codecov % error issue.

@imskr
Copy link
Contributor Author

imskr commented Jul 18, 2019

It is showing one check wrong because previous due to error coverage was 100% but now it is less than it. Now it is correctly showing.

Copy link
Member

@mekarpeles mekarpeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, waiting on @jbuckner to confirm. Thanks @imskr !

Copy link
Contributor

@jbuckner jbuckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Nice job!

@jbuckner jbuckner merged commit ae61e8a into internetarchive:master Jul 24, 2019
@imskr imskr deleted the skr-patch branch July 24, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants