Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToC icon display if enableChaptersPlugin #1289

Merged
merged 2 commits into from Dec 19, 2023
Merged

Conversation

dualcnhq
Copy link
Collaborator

@dualcnhq dualcnhq commented Dec 16, 2023

Testing:

@dualcnhq dualcnhq requested a review from cdrini December 16, 2023 11:02
@dualcnhq dualcnhq marked this pull request as draft December 17, 2023 13:52
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6beb85) 69.28% compared to head (95851b7) 69.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1289   +/-   ##
=======================================
  Coverage   69.28%   69.29%           
=======================================
  Files          59       59           
  Lines        5079     5080    +1     
  Branches     1068     1068           
=======================================
+ Hits         3519     3520    +1     
  Misses       1533     1533           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dualcnhq dualcnhq marked this pull request as ready for review December 18, 2023 09:35
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ; one suggestion/question.

tests/jest/BookNavigator/book-navigator.test.js Outdated Show resolved Hide resolved
@dualcnhq dualcnhq merged commit fd083e7 into master Dec 19, 2023
12 checks passed
@dualcnhq dualcnhq deleted the webdev-6546-toc-icon branch December 19, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants