Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

320/bug/autoplay e2e fails #344

Merged

Conversation

giacomo-cgn
Copy link
Collaborator

Closes #320
Random delay between flipping the book cover and the first page caused unexpected test failures.
Added longer wait time to cover for these randoms delays (before it was assumed that delay was always 0)
From: 3000ms -> 2% fails (original)
to: 4000ms -> 0% fails

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #344 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   60.83%   60.78%   -0.06%     
==========================================
  Files          32       32              
  Lines        3409     3409              
  Branches      646      646              
==========================================
- Hits         2074     2072       -2     
- Misses       1071     1073       +2     
  Partials      264      264              
Impacted Files Coverage Δ
src/js/plugins/tts/WebTTSEngine.js 65.41% <0.00%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e0b4b...3be2367. Read the comment docs.

Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm! Could you rebase? That should fix travis :)

@cdrini cdrini force-pushed the 320/bug/autoplayE2E-fails branch from b7aed4e to 3be2367 Compare June 5, 2020 22:09
@cdrini cdrini merged commit efe762d into internetarchive:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoplay plugin E2E test sometimes fails randomly
2 participants