Fixed advanced demo not turning pages #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index is invalid in _getDataProp
cdrini
force-pushed
the
358-fix-demoAdvanced
branch
from
b578341
to
5f13a31
Compare
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 64.74% 64.61% -0.13%
==========================================
Files 32 32
Lines 3469 3468 -1
Branches 660 659 -1
==========================================
- Hits 2246 2241 -5
- Misses 981 983 +2
- Partials 242 244 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was fixed by returning fallback value if index is invalid in
_getDataPropfunction.Also affected
/demo-plugin-menu-toggle.htmland/demo-advanced.html.closes #358