Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java interface text editor error when saving crawler-beans.cxml #293

Closed
ArtHoff opened this issue Jan 15, 2020 · 2 comments · Fixed by #294
Closed

Java interface text editor error when saving crawler-beans.cxml #293

ArtHoff opened this issue Jan 15, 2020 · 2 comments · Fixed by #294
Assignees
@ato
Labels
bug

Comments

@ArtHoff
Copy link

ArtHoff commented Jan 15, 2020

Hi,
Since the August 2019 releases I am unable to save the crawler-beans.cxml from the editor. The last version of Heritrix that works for me is: 3.4.0-SNAPSHOT-2019-08-05T04:18:15Z.
I've tried on different machines and the behaviour is the same.
When I click save I get the following message:
An error occurred
You may be able to recover and try something else by going back.

image
image
Thanks
@ato ato self-assigned this Jan 15, 2020
@ato
Copy link
Collaborator

ato commented Jan 15, 2020

I can reproduce. It's returning 405 Method Not Allowed. This was likely introduced by #283, but I could have sworn I tested this.

Thanks for reporting, I'll try to have a fix soon.

ato added a commit that referenced this issue Jan 15, 2020
@ato
Fix 'Method Not Allowed' on POST of config editor form
34be934 
Under Restlet 2 `getVariants()` always returns null for a POST so our
post() method was never called and 405 Method Not Allowed was returned.
We don't need content negotiation for the POST response anyway so let's
instead override the no-variants post() like we do for put().

Fixes #293
@ato ato mentioned this issue Jan 15, 2020
Merged
@ato ato added the bug label Jan 15, 2020
@ArtHoff
Copy link
Author

ArtHoff commented Jan 30, 2020

Thank you so much for the quick fix.

hennekey pushed a commit to hennekey/heritrix3 that referenced this issue Feb 13, 2020
@ato @hennekey
Fix 'Method Not Allowed' on POST of config editor form
2bcc620 
Under Restlet 2 `getVariants()` always returns null for a POST so our
post() method was never called and 405 Method Not Allowed was returned.
We don't need content negotiation for the POST response anyway so let's
instead override the no-variants post() like we do for put().

Fixes internetarchive#293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ato ato

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 'Method Not Allowed' on POST of config editor form internetarchive/heritrix3
2 participants
@ato @ArtHoff