Fix jobdir PUT #283
Merged
Fix jobdir PUT #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression introduced in the upgrade to Restlet 2. I encountered a NullPointerException here when upgrading and misunderstood the cause of it. Since PUT and DELETE return no content they are actually supposed to return null.
Fixes #282 and HER-1907
|
Yes! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch fixes regression #282 where PUT and DELETE on jobdir files return 405 Method Not Allowed.
With the first patch applied PUT still doesn't behave correctly though as Restlet unhelpfully changes the file extension cxml to xml. This behaviour affected Restlet 1 for other file types as described in HER-1907 however was mitigated for .cxml by registering it as the application/xml content-type. Under Restlet 2 the extension resolution appears to have changed so that always .xml gets picked.
The second patch overrides PUT to disable the file extension manipulation entirely.