Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQPUrlReceiver changes to support RabbitMQ >= 3.3 #128

Merged
merged 3 commits into from
Sep 24, 2015

Conversation

anjackson
Copy link
Collaborator

As of version 3.3, RabbitMQ no longer supports channel.flow{active=false} and so the AMQPUrlReceiver module is lot able to use this method to pause message consumption. This patch:

  • Switches to a consume/cancel model so the UrlConsumer only runs when the crawl is running.
  • Separates consumption from the StarterRestarter, making both more robust.
  • Prevents unanticipated exceptions from killing the StarterRestarter thread.
  • Enables the durability and auto-delete features of the queues to be modified via Spring.

nlevitt added a commit that referenced this pull request Sep 24, 2015
AMQPUrlReceiver changes to support RabbitMQ >= 3.3
@nlevitt nlevitt merged commit 41dac25 into internetarchive:master Sep 24, 2015
@nlevitt
Copy link
Contributor

nlevitt commented Sep 24, 2015

Seems to be working for me. Thanks!

@anjackson
Copy link
Collaborator Author

Thanks! I should have probably made it clear that we are running this at scale (UK domain crawl) on a almost-HEAD version of H3 and it's working fine.

@anjackson anjackson deleted the amqp-url-receiver-changes branch November 19, 2015 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants