New account settings design #2

nsharma123 · 2023-05-16T13:04:04Z

No description provided.

Add the base set of IA-customizations. Changes: - Add .travis.yml file - Change LICENSE to AGPL - Add badges to Readme - Set base font size - Add circular dependency checking - Export types - Add sinon for test-helpers - Update typescript - Update some eslint settings

This makes it easier to create module demos since you can use Typescript all the way down.

* Add initial GitHub actions setup * Remove Travis CI script and remove format script in GitHub Actions CI

This fixes an erroneous eslint typescript warning

Travis CI was removed in favor of GitHub Actions in #2.

@web/test-runner was using an older version of puppeteer, which wasn't working for M1 Macs. Now it's updated to a newer version.

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Add GH pages config + update Github actions build script * Update README with details about build scripts and steps on setting up Github pages

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This reverts commit 2b38a9b.

…rnetarchive/iaux-account-settings into new-account-settings-design

github-actions · 2023-06-06T07:08:16Z

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-06-29 21:08 UTC

iisa

hello, midway through code review - I've added some comments, suggestions, questions for discourse 🙂

q: can we make demo workable?

demo/index.html

package.json

src/models.ts

src/ia-account-settings.interface.ts

src/ia-account-settings.ts

latonv

Nice job on this! Lots of solid work.

I pointed out what seems like a blocker in the email availability condition which should be addressed. Otherwise, just some other suggestions & questions throughout to help improve code clarity and type accuracy.

demo/index.html

src/ia-account-settings.ts

src/services/backend-service.ts

src/services/util.ts

test/ia-account-settings.test.ts

latonv

Thanks for the updates! Just had some more suggestions & questions on a few things.

src/components/authentication-template.ts

src/ia-account-settings.ts

src/services/util.ts

latonv

LGTM, just a few final small suggestions.

Also, just a reminder to add linting back to the test script before merge, as @iisa noted.

src/assets/eye.-open.ts

src/ia-account-settings.ts

package.json

jbuckner and others added 30 commits March 5, 2021 13:56

Initial OpenWC scaffolding

4da7d07

Update Readme badge URLs

36673bb

Update Readme with better usage instructions

fad036c

Update the demo to use an <app-root> component (#3)

195411d

This makes it easier to create module demos since you can use Typescript all the way down.

Add initial GitHub actions setup (#2)

ed22cd3

* Add initial GitHub actions setup * Remove Travis CI script and remove format script in GitHub Actions CI

Add Codecov to CI (#7)

cccccc1

Improve eslint settings

11496fb

This fixes an erroneous eslint typescript warning

Update app-root demo

c5e7b33

Style update in the demo app

961942a

Remove Travis CI references from README (#8)

9cfe2f5

Travis CI was removed in favor of GitHub Actions in #2.

Update @web/test-runner to work with M1 macs

b79a967

@web/test-runner was using an older version of puppeteer, which wasn't working for M1 Macs. Now it's updated to a newer version.

Update to Lit2

3e03ab6

Update github actions to use node 16

9080322

Update dev dependencies to latest (#9)

e0e30bf

Add repository section to package.json

a23782a

add codecov badge example and installation info (#11)

0e91641

Add renovate.json (#10)

4ffafa3

Co-authored-by: Renovate Bot <bot@renovateapp.com>

renovate config update to preserve semver ranges

4f11731

Update actions/checkout action to v3 (#15)

c51cc78

Co-authored-by: Renovate Bot <bot@renovateapp.com>

Update actions/setup-node action to v3 (#16)

71057bd

Co-authored-by: Renovate Bot <bot@renovateapp.com>

Update dependency concurrently to v7 (#17)

d8bdf3c

Co-authored-by: Renovate Bot <bot@renovateapp.com>

Update dependency sinon to v14 (#19)

91f5af0

Co-authored-by: Renovate Bot <bot@renovateapp.com>

Update dependency husky to v8 (#18)

67d8544

Co-authored-by: Renovate Bot <bot@renovateapp.com>

upgrade all deps (#20)

437623f

WEBDEV-4269 - Github workflows (#21)

e6d288b

* Add GH pages config + update Github actions build script * Update README with details about build scripts and steps on setting up Github pages

add ts rule: importsNotUsedAsValues (#25)

b781e26

Update dependency @web/test-runner to ^0.14.0 (#26)

fefd779

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency vite to v3 (#23)

b8fd6d7

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update JamesIves/github-pages-deploy-action action to v4.4.0 (#22)

253fe31

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate bot and others added 9 commits February 8, 2023 11:54

Update dependency gh-pages to v5 (#35)

ac7319b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency madge to v6 (#36)

cca1f0f

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Initial commit

2b38a9b

Revert "Initial commit"

3d817a8

This reverts commit 2b38a9b.

Initial changes

0a3ceac

Merge branch 'new-account-settings-design' of https://github.com/inte…

752dfd6

…rnetarchive/iaux-account-settings into new-account-settings-design

vv1.22.5

e07fb58

implement profile page with ia-pic-uploader

b22649a

Lots of changes for account-settings stuff

0b7e153

nsharma123 added 2 commits June 9, 2023 15:10

More refactoring changes for pic-uploader

85e7416

Fixing google auth problem with isa

db89971

iisa requested changes Jun 16, 2023

View reviewed changes

latonv suggested changes Jun 16, 2023

View reviewed changes

nsharma123 added 4 commits June 16, 2023 18:02

Addressed code review suggestions

e36ce53

change error message

7ce0ac4

Added suggestion from ux-forum

37d1cf3

Data consistency

8399391

latonv reviewed Jun 21, 2023

View reviewed changes

nsharma123 added 6 commits June 22, 2023 18:27

change show password functionality

150695d

Addressed some suggestion for types

c73cc5d

write test case & version update to 53

a72438e

add csrf token

1c8b105

Added csrf token support for frontend forms

8ea82f7

Change success messaging structure

7605dc4

latonv approved these changes Jun 27, 2023

View reviewed changes

src/assets/eye.-open.ts Outdated Show resolved Hide resolved

src/ia-account-settings.ts Outdated Show resolved Hide resolved

src/ia-account-settings.ts Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

nsharma123 added 3 commits June 29, 2023 15:56

Updated ia-pic-uploader version

4d62709

Remove some bugs on message section

6ca78c7

Minor feedback

25e10d6

nsharma123 merged commit efc83e4 into main Jun 29, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New account settings design #2

New account settings design #2

nsharma123 commented May 16, 2023

github-actions bot commented Jun 6, 2023 •

edited

iisa left a comment

latonv left a comment

latonv left a comment

latonv left a comment

New account settings design #2

New account settings design #2

Conversation

nsharma123 commented May 16, 2023

github-actions bot commented Jun 6, 2023 • edited

iisa left a comment

Choose a reason for hiding this comment

latonv left a comment

Choose a reason for hiding this comment

latonv left a comment

Choose a reason for hiding this comment

latonv left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 6, 2023 •

edited