WEBDEV-6909 Add radio search backend #54
Conversation
| window.history.replaceState({}, '', url.toString()); | ||
| }); | ||
|
|
||
| it('includes reCache param from URL if not provided', async () => { |
There was a problem hiding this comment.
| it('includes reCache param from URL if not provided', async () => { | |
| it('includes reCache param from URL if provided', async () => { |
looks like recache is set in stub
There was a problem hiding this comment.
Thanks, I've rewritten the test descriptions to be clearer around this. "Provided" here was supposed to mean "provided as an option" which is now explicitly spelled out. The purpose of these tests is: if we don't receive a caching option from the caller, check whether there is a cache directive in the URL and use that instead if so.
| const response = await backend.performSearch({ query: 'foo' }); | ||
| expect(response).to.exist; // No error thrown | ||
| expect(response.error).to.be.instanceof(SearchServiceError); | ||
| expect(response.error?.type).to.equal(SearchServiceErrorType.networkError); |
There was a problem hiding this comment.
is network error the default error?
There was a problem hiding this comment.
Not in general, no. But in this test, we are mocking window.fetch calls to return an error, which results in the networkError code from the service.
| async performSearch( | ||
| params: SearchParams | ||
| ): Promise<Result<any, SearchServiceError>> { | ||
| if (this.debuggingEnabled && params.debugging === undefined) { |
There was a problem hiding this comment.
debugging is allowed to be explicitly set to true or false on a search, which overrides any global default setting in the search service. So this line is just saying "if no debugging value was provided as an option, use the default".
!params.debugging would change the logic, as it would no longer be possible to override the default by providing false.
|
noting build is failing |
latonv
force-pushed
the
webdev6909-radio-search-backend
branch
from
2b4fec5
to
f8ec5ad
Compare
|
|
Build issues fixed -- the node version in our CI config was outdated. |
Adds a new search backend for requesting radio caption hits from the PPS, updating models to account for this new search type.