WEBDEV-7001 Build federated search "backend" #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 12, 2024 15:02
|
rebecca-shoptaw
commented
Sep 13, 2024
| * Optional. | ||
| * Start time for TV hit. | ||
| */ | ||
| @Memoize() get start(): StringField | undefined { |
There was a problem hiding this comment.
This is the only prop that differs from full-text search! Replaces page_num.
rebecca-shoptaw
commented
Sep 13, 2024
| for (const service of SEARCH_SERVICES) { | ||
| this.federatedResults | ||
| ? (this.federatedResults[service] = []) | ||
| : (this.federatedResults = { [service]: [] }); |
There was a problem hiding this comment.
This probably could/should be split into sub-functions for clarity.
rebecca-shoptaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new search type (
SearchType.FEDERATED) to the search service to fetch federated results from the new PPS endpoint. Intended to be used for search prototyping.Current endpoint service names:
TODOs throughoutfull_texttv_captionsradio_captionsmedia_transcriptionAccessing results:
response.pageElements.full_text.hits--> a full rawhitsobject with totals, returned count, and an array of hitsresponse.federatedResults.full_text--> an array of hits correctly formatted asTextHit,TVClipHit, etc.Note: