-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bot Class #178
Add Bot Class #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should we drop support for Python 2? |
I'm stuck on the logging feature of the bot. Here's a truncated log from the failed test:
I think the problem might be the logger is writing to Simply intializing the bot used to throw this error, but then i set
|
Is the result identical on Python 3.7 or 3.8? |
Alas, I have found a solution! The problem was Paging for @cdrini and @mekarpeles for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! Some code cleanup things, but this is looking greeeeat!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. All comments are OPTIONAL.
I believe that we can comment out this line so the tests pass. ;-) |
There might still be some residual code with py2/3 code, but no longer test on/say that we support py 2 Co-authored-by: Christian Clauss <cclauss@me.com>
…aking_a_bot example. Conform code style.
Co-authored-by: Christian Clauss <cclauss@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's 🚀 this PR! Merging once travis done 👍
You'll need to cleanup your master (why you should always use branches :) )
|
Provide a useful bot class that future bots can inherit from. Also provide an example script.