Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate get_from_local() and get_data() from get_ia.py? #1532

Closed
cclauss opened this issue Nov 6, 2018 · 2 comments · Fixed by #3054
Closed

Eliminate get_from_local() and get_data() from get_ia.py? #1532

cclauss opened this issue Nov 6, 2018 · 2 comments · Fixed by #3054
Assignees
@cdrini
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
Triage

Comments

@cclauss
Copy link
Collaborator

cclauss commented Nov 6, 2018 •
edited

https://github.com/internetarchive/openlibrary/blob/master/openlibrary/catalog/get_ia.py#L223-L251

Deprecated in #1058 and raising undefined name issues in #1508 (output), can these two functions be eliminated as dead code? @cdrini
@cdrini
Copy link
Collaborator

cdrini commented Aug 14, 2019

This will be harrier. PyCharm finds a number of references. I would try to remove them in separate PRs, following references (and searching for their names, because PyCharm misses some references) and removing methods that call those methods and that don't except any errors.

I think large swathes of the catalog/ scripts appear to be dead code; is that right, @hornc ?

@cdrini cdrini added the Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] label Aug 14, 2019
@xayhewalo xayhewalo added this to Un-Triaged in Triage Oct 20, 2019
@xayhewalo xayhewalo added State: Backlogged Priority: 3 Issues that we can consider at our leisure. [managed] labels Nov 20, 2019
@xayhewalo
Copy link
Collaborator

Gonna assign @cdrini since he's making the PRs

@xayhewalo xayhewalo moved this from Un-Triaged to Triaged in Triage Nov 20, 2019
@mekarpeles mekarpeles added the Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] label Dec 18, 2019
@hornc hornc mentioned this issue Feb 25, 2020
Merged
4 tasks
Triage automation moved this from Triaged to Closed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrini cdrini

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
No open projects
Triage
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/3049 catalog clean out (pt2) internetarchive/openlibrary
4 participants
@mekarpeles @cclauss @cdrini @xayhewalo