Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create work independent of edition #2138

Closed
seabelis opened this issue May 21, 2019 · 5 comments · Fixed by #2668
Closed

Create work independent of edition #2138

seabelis opened this issue May 21, 2019 · 5 comments · Fixed by #2668
Assignees
Labels
Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] Editions Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Milestone

Comments

@seabelis
Copy link
Collaborator

Description

Changing title in "What work is this an edition of?" no longer creates new work. And since it is not possible to create a new work without an actual edition to associate with it, it is not possible to move incorrectly associated editions if the work does not already exist.

Evidence / Screenshot (if possible)

Relevant url?

https://openlibrary.org/books/OL1889320M/The_book_of_questions
This is not the same as the work it is associated with. It does not exist yet as a work.

Expectation

Previously, I would change the title in the "What work is this an edition of?" field and the edition would be moved to a new work.

Details

  • Logged in (Y/N)? Y
  • Browser type/version? Version 74.0.3729.157 (Official Build) (64-bit)
  • Operating system? Win 7 Pro

Proposal & Constraints

Stakeholders

@seabelis seabelis added Editions Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] labels May 21, 2019
@mekarpeles
Copy link
Member

@cdrini do you mind taking a look at this? Is this related to recent changes we've made?

@mekarpeles
Copy link
Member

Feature requires move edition drop-down to have "change work" should have a create new

Fact that this used to work was a bug (or undocumented feature).

@LeadSongDog
Copy link

As currently on prod, this does seem to function better than previously. That said, when the merged work ID is inserted, there is only a brief appearance of the work title. Once the user clicks on the title, it returns to showing just the work id. It would be better if both the ID and the work title were visible. A similar thing could be said about edits to the author field. Once the suggestion is clicked, it is hard to tell which John Smith has been accepted except by saving and remembering to click-through to verify. Actually showing the author ID beside the author name would improve transparency.

@cdrini cdrini added this to High priority in Librarian Issues May 31, 2019
@cdrini cdrini moved this from High priority to Needs triage in Librarian Issues May 31, 2019
@seabelis seabelis moved this from Needs triage to High priority in Librarian Issues Jul 16, 2019
@seabelis seabelis moved this from High priority to Needs triage in Librarian Issues Jul 30, 2019
@seabelis seabelis moved this from Needs triage to High priority in Librarian Issues Jul 30, 2019
@xayhewalo xayhewalo added this to Un-Triaged in Triage Oct 18, 2019
@seabelis seabelis changed the title Changing title in "What work is this an edition of?" no longer creates new work. Create work independent of edition Oct 23, 2019
@seabelis
Copy link
Collaborator Author

Related to #352?

@LeadSongDog
Copy link

@seabelis
Well, peripherally related, but when an orphan edition record exists, an author OLID also exists already and should be referenced in that edition record. Creating a work record should remove the reference to the author OLID from the extant edition at the same time it adds a linked work OLID. Normally this should happen when someone hits the "add another" [edition] link.

@xayhewalo xayhewalo added Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Priority: 2 Important, as time permits. [managed] State: Backlogged Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] labels Nov 12, 2019
@xayhewalo xayhewalo moved this from Un-Triaged to Triaged in Triage Nov 12, 2019
@cdrini cdrini added State: Work In Progress This issue is being actively worked on. [managed] and removed State: Backlogged labels Nov 15, 2019
@cdrini cdrini added this to User Experience in 2019 Epics Nov 27, 2019
@cdrini cdrini added this to the 2019-Q4 milestone Nov 27, 2019
@mekarpeles mekarpeles added the Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] label Dec 18, 2019
2019 Epics automation moved this from User Experience to Done (or Needs Review) Dec 20, 2019
Triage automation moved this from Triaged to Closed Dec 20, 2019
Librarian Issues automation moved this from High priority to Closed Dec 20, 2019
@cdrini cdrini removed the State: Work In Progress This issue is being actively worked on. [managed] label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] Editions Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
Librarian Issues
  
Closed
2019 Epics
  
Done (or Needs Review)
Triage
  
Closed
Development

Successfully merging a pull request may close this issue.

5 participants