Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a mismatch of availability of a book in a thumbnail to its true status #2616

Closed
BrittanyBunk opened this issue Nov 10, 2019 · 9 comments
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects

Comments

@BrittanyBunk
Copy link
Contributor

BrittanyBunk commented Nov 10, 2019

Example:

https://openlibrary.org/books/OL26571490M/Flush
https://openlibrary.org/books/OL26571491M/A_haunted_house_and_other_short_stories
image

Problem:

Works in carousel say 'read', but when clicked on says 'no ebook available'. The expected result should be a read button there.

Solution:

Change the carousel to match the availability of the edition (as what shows on the editions page is the true status)

Stakeholders

Users - this issue creates confusion and frustration for someone hoping to see a book only to find out it's not available.

@BrittanyBunk BrittanyBunk added the Type: Bug Something isn't working. [managed] label Nov 10, 2019
@BrittanyBunk BrittanyBunk changed the title Works in carousel say it can be borrowed, but when clicked on says 'no ebook available' Works in carousel say 'borrow', but when clicked on says 'no ebook available' Nov 10, 2019
@BrittanyBunk BrittanyBunk changed the title Works in carousel say 'borrow', but when clicked on says 'no ebook available' Works in carousel say 'read', but when clicked on says 'no ebook available' Nov 10, 2019
@xayhewalo xayhewalo added this to Un-Triaged in Triage Nov 10, 2019
@xayhewalo xayhewalo added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged labels Nov 25, 2019
@xayhewalo xayhewalo moved this from Un-Triaged to Needs: Assessment in Triage Nov 25, 2019
@xayhewalo
Copy link
Collaborator

@BrittanyBunk "Read" is now taking me to the Works pages. Is the same happening for you? If so can we close this issue?

@BrittanyBunk
Copy link
Contributor Author

@guyjeangilles still happening. Like https://openlibrary.org/works/OL39416W/Virginia_Woolf to click on https://openlibrary.org/books/OL1557874M/Women_fiction. In the carousel, it says 'read'. When clicking on it, it goes to the edition page, but says 'no ebook available'

@mekarpeles mekarpeles added Good First Issue Easy issue. Good for newcomers. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] labels Mar 23, 2020
@Loquen
Copy link
Contributor

Loquen commented Mar 30, 2020

@BrittanyBunk I'm trying to understand the issue here, what is the expected result of clicking 'read'? Should we change the wording to something other than 'read' or does the button need to redirect to another page?

@BrittanyBunk BrittanyBunk changed the title Works in carousel say 'read', but when clicked on says 'no ebook available' There is a mismatch of availability of a book in a carousel to its true status Mar 30, 2020
@BrittanyBunk
Copy link
Contributor Author

@Loquen I apologize. I reworded it. Check out what I wrote :)

@Loquen
Copy link
Contributor

Loquen commented Apr 2, 2020

@BrittanyBunk Much clearer! Thanks for clarifying. So the solution seems to be if a book has a borrowable edition display it instead of the editions not in the library. If a book has only issues that are not in the library we can change the wording of the button to 'Not In Library' or something while still directing users to the books detail page.

@BrittanyBunk
Copy link
Contributor Author

I think you're referring more to another issue I created: #3248. You're specifying though - as what are in carousels are mostly works, so it should redirect to the most available edition - that is a good thought! What I'm referring to here is if a book is in a carousel, then its availability would need to match, no matter what it is. No ebook -> no ebook, read -> read, borrow -> borrow, etc.

@BrittanyBunk
Copy link
Contributor Author

I found the reason why!
The button (read, borrow, etc.) link to a book in the IA, while the book covers connect to the Work page of the OL edition webpage of the button.

@mekarpeles mekarpeles removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Apr 20, 2020
@mekarpeles
Copy link
Member

Should be resolved now

@BrittanyBunk
Copy link
Contributor Author

@mekarpeles this is still an issue as it's been brought up again in #4379. Please reopen, so there's no duplicates.

@BrittanyBunk BrittanyBunk changed the title There is a mismatch of availability of a book in a carousel to its true status There is a mismatch of availability of a book in a thumbnail to its true status Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
No open projects
Triage
  
Needs: Assessment
Development

No branches or pull requests

4 participants