Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete or fix TestAccount tests #2701

Open
cdrini opened this issue Dec 6, 2019 · 1 comment
Open

Delete or fix TestAccount tests #2701

cdrini opened this issue Dec 6, 2019 · 1 comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Dec 6, 2019

This test class has been xfail-ed since 2017 (c325149); as of #2595 , a lot of the endpoints the tests reference (e.g. /account/email) have been removed as dead code. This should also be deleted if it's no longer relevant.

openlibrary/openlibrary/plugins/upstream/tests/test_account.py

Lines 24 to 25 in 7e086e9

@pytest.mark.xfail
class TestAccount:

Stakeholders

@hornc @jdlrobson
@cdrini cdrini added the Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] label Dec 6, 2019
@xayhewalo xayhewalo added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged labels Dec 9, 2019
@hornc hornc changed the title Delete or fix TestAccount file Delete or fix TestAccount tests Dec 17, 2019
@mekarpeles mekarpeles added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Apr 18, 2020
@Yashs911
Copy link
Contributor

@cdrini I would like to work on this issue.
Currently, the class is located here:

openlibrary/openlibrary/plugins/upstream/tests/test_account.py

Lines 165 to 166 in 492f402

@pytest.mark.xfail
class TestAccount:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mekarpeles @cdrini @xayhewalo @Yashs911