Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List search only finds exact matches #2723

Open
jessamynwest opened this issue Dec 12, 2019 · 4 comments
Open

List search only finds exact matches #2723

jessamynwest opened this issue Dec 12, 2019 · 4 comments
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Priority: 2 Important, as time permits. [managed] Theme: Lists Issues related to reading Lists Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@jessamynwest
Copy link
Collaborator

jessamynwest commented Dec 12, 2019

Blocked by: #2609

Expanding on #364 Improve and expand list searching to search inside list titles.

A List search result is only given if the exact, full name of a list is used in the search. Searching on words that are only part of a list name returns "No results found."

Relevant url?

https://openlibrary.org/search/lists

Steps to Reproduce

  1. Go to ... https://openlibrary.org/search/lists
  2. Do ... enter a partial list name, for example, https://openlibrary.org/search/lists?q=banned
  • Actual: only exact matches returned
  • Expected: any list containing search term should be returned

Proposal & Constraints

We can now replace lists search with solr-backed list search since lists are now in solr! To do so, we will need to add a new SearchScheme for lists, and wire up the lists search.

Related files

Stakeholders

@cdrini @seabelis @el4ctr0n

@jessamynwest jessamynwest added the Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] label Dec 12, 2019
@xayhewalo xayhewalo added Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged Theme: Search Issues related to search UI and backend. [managed] labels Dec 12, 2019
@xayhewalo
Copy link
Collaborator

@cdrini @tfmorris I'm assuming list search is a Solr feature? Will that be apart of the reindex?

@BrittanyBunk
Copy link
Contributor

BrittanyBunk commented Dec 27, 2019

You're asking for a search bar for a list when clicking on it? This really is part of a bigger issue, where when clicking on anything - authors, works, etc. - it's not possible to alphabetize or search. I mentioned it on #2741 too, but for authors. I believe I also created a github issue for works/editions, but maybe someone else could find that #.

@tfmorris
Copy link
Contributor

@guyjeangilles It would be a combination of UI plus Solr. It's a new feature which would not fall naturally out of the general Solr upgrade project.

@mekarpeles mekarpeles removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Apr 20, 2020
@cdrini cdrini added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] and removed Needs: Lead labels Apr 20, 2020
@cdrini cdrini removed the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Jun 11, 2024
@cdrini cdrini changed the title Improve list search List search only finds exact matches Jun 11, 2024
@cdrini cdrini added Priority: 2 Important, as time permits. [managed] Theme: Lists Issues related to reading Lists and removed Priority: 3 Issues that we can consider at our leisure. [managed] labels Jun 11, 2024
@cdrini
Copy link
Collaborator

cdrini commented Jun 11, 2024

Update: Lists are now in solr so this is no longer blocked! I updated the description with instructions. Here's a sample list record in our solr:

{
      "key":"/people/ScarTissue/lists/OL228125L",
      "name":"Cookbooks",
      "seed":["/works/OL8941312W","/works/OL189773W","/books/OL36885385M"],
      "type":"list",
      "subject":["Cookery","Cooking","Cooking, french","Cuisine en plein air","Dictionaries","English","French","French Cookery","French Cooking","French language","Outdoor cooking","Picnicking","Picnics","Pique-niques"],
      "subject_facet":["Cookery","Cooking","Cooking, french","Cuisine en plein air","Dictionaries","English","French","French Cookery","French Cooking","French language","Outdoor cooking","Picnicking","Picnics","Pique-niques"],
      "_version_":1796111292365275138,
      "subject_key":["cookery","cooking","cooking_french","cuisine_en_plein_air","dictionaries","english","french","french_cookery","french_cooking","french_language","outdoor_cooking","picnicking","picnics","pique-niques"]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Priority: 2 Important, as time permits. [managed] Theme: Lists Issues related to reading Lists Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

No branches or pull requests

6 participants