New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address CORS issues with Open Library API endpoints #329
Comments
As noted in #220, of the various API's listed on https://openlibrary.org/dev/docs/api/, the search.json API is now open to cross-domain requests, but the others are not and should be addressed. |
Still an issue. I don't really have any that much experience with server configs, but I could try to poke around and submit a PR unless someone could just fix it quickly? |
Can investigate |
That would be very much appreciated! |
It looks like within openlibrary/openlibrary/plugins/openlibrary/processors.py there's a class In a previous commit, I see highlighted: Which I can confirm is getting triggered via http://openlibrary.org/api/books?bibkeys=ISBN:0201558025&jscmd=data&format=json nginx also seems to be behaving correctly
|
@danielancines I believe I have this fixed for /api/books on our dev server. The endpoint will need to be called w/ .json. https://dev.openlibrary.org/api/books.json?bibkeys=ISBN:0201558025&jscmd=data&format=json The current endpoint Proposal is to add a route of the form: class books_json(delegate.page):
|
Please continue to open bugs as specific json endpoints are needed and we can make this prescribed change. |
Closing -- please re-open with a specific endpoint which requires enabling cors, or if #570 did not resolve the issue |
Think you forgot to close 😉 Also, thanks! 🙌 |
Unfortunately, it seems like the CORS issue still persists for the Covers API. Is there any way this endpoint can be adjusted as well? |
still giving cors error when trying to access the following api (angular) this.http.get(`https://openlibrary.org/isbn/9780385513227
`).subscribe(e => {
next: (res: any) => console.log(res)
}) |
Also an issue with |
I'm using angular $http feature to access the Open Library and I've got cors error
Looking for this at Google I found this link with this same error, are you'll look for this someday?
#220
https://plnkr.co/edit/OPc95v?p=preview
Thanks.
The text was updated successfully, but these errors were encountered: