Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IA_BASE_URL not being read from openlibrary.yml #4437

Open
cdrini opened this issue Jan 19, 2021 · 1 comment · May be fixed by #8610
Open

Fix IA_BASE_URL not being read from openlibrary.yml #4437

cdrini opened this issue Jan 19, 2021 · 1 comment · May be fixed by #8610
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Jan 19, 2021

IA_BASE_URL is read in a few places before config is initialized! We can't easily test OL hooked to IA review apps

openlibrary/openlibrary/core/ia.py

Lines 19 to 21 in b3541fd

# FIXME: We can't reference `config` in module scope like this; it will always be undefined!
# See lending.py for an example of how to do it correctly.
IA_BASE_URL = config.get('ia_base_url', 'https://archive.org')

Stakeholders

@cclauss @dherbst
@cdrini cdrini added Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jan 19, 2021
@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jan 25, 2021
@mekarpeles mekarpeles added the Good First Issue Easy issue. Good for newcomers. [managed] label Sep 7, 2023
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] and removed Priority: 2 Important, as time permits. [managed] labels Oct 26, 2023
@krishnapatel17
Copy link

krishnapatel17 commented Nov 24, 2023 •
edited

Can I please take on this issue? @cclauss

@krishnapatel17 krishnapatel17 linked a pull request Dec 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ia.py to fix the undefined IA base url krishnapatel17/openlibrary
3 participants
@mekarpeles @cdrini @krishnapatel17