Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affiliate API: Supplement/import missing data & failed search results #4465

Open
2 tasks
mekarpeles opened this issue Jan 22, 2021 · 2 comments
Open
2 tasks
Labels
Lead: @scottbarnes Issues overseen by Scott (Community Imports) Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Priority: 2 Important, as time permits. [managed] Theme: Affiliate API

Comments

@mekarpeles
Copy link
Member

Continuation of #1322

  1. When Affiliate Server pulls data, if that data is not in OL (e.g. a missing cover), let's make sure to back-fill and improve over time
  2. Let's see if we can extend our usage of the affiliate APIs so if our search result returns no hits, we may still show / perhaps import results.

Describe the problem that you'd like solved

Proposal & Constraints

Additional context

Stakeholders

@mekarpeles mekarpeles added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Priority: 2 Important, as time permits. [managed] Theme: Affiliate API and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jan 22, 2021
@BrittanyBunk
Copy link
Contributor

I do like the idea of bringing to attention what's missing in the OL so that it can be filled out more. That is probably the # 1 issue on the OL and so I understand the need to fix it.

So what you're saying is for some (I forgot the term) automated moderator will look for missing info on the OL and when an item's pulled and try to fill in what's missing. Cool (if I'm understanding right) - I mean that is nice if that's able to be created.

Like if it pulls from the internet, that'd be neat. What I'm thinking is maybe have a mode to where a bot pulls info from the internet and anyone who clicks the edit button would be given options to add in what the bot pulled by clicking on them.

Examples:

  • author: Dr. Seuss and it's surrounded by a red dashed square. Then people can click it to add it in if it's correct
  • if the bot doesn't know the correct one, then there's multiple choices and it's up to a person to add the correct one or their own.

Cool - I like the streamlining idea to lessen the workload for people. Now how do we make that happen lol is the question.

@mekarpeles
Copy link
Member Author

As mentioned in #6953

Affiliate Service (weekend outage fix) + Check imports succeeding (esp. amazon)

  • Set a max buffer size to our isbn queue of 1,000 Let’s use this PR to verify.
  • Set a Sentry alert if queue size is 1,000 Enabler is this PR + Graphana alert (which can already raise a Slack).
  • Create an endpoint to clear the queue? Done in this PR
  • Change cache for 24 hours. Let’s use this PR to verify.

@mekarpeles mekarpeles added Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] and removed Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] labels Sep 15, 2023
@mekarpeles mekarpeles added Needs: Lead Lead: @scottbarnes Issues overseen by Scott (Community Imports) and removed Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] Needs: Lead labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @scottbarnes Issues overseen by Scott (Community Imports) Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Priority: 2 Important, as time permits. [managed] Theme: Affiliate API
Projects
None yet
Development

No branches or pull requests

2 participants