Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can collection carousel display be sorted by # of editions or availability? #4493

Closed
seabelis opened this issue Jan 26, 2021 · 2 comments
Closed

Can collection carousel display be sorted by # of editions or availability? #4493

seabelis opened this issue Jan 26, 2021 · 2 comments
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Question This issue doesn't require code. A question needs an answer. [managed]

Comments

@seabelis
Copy link
Collaborator

Question

Can collection carousel display be sorted by # of editions or availability?

Additional context

For example, if the results of a query include public domain, lending library, and print-disabled, the ability to sort or filter on the type best suited for the collection would be helpful. See https://openlibrary.org/collections/happy-new-year-2021 where many 'not in library' results appear when there are also borrowable works available.

Issue resolution criteria

This can be closed if a solution is provided or if it is not going to be implemented.

Stakeholders

@seabelis @mekarpeles
@seabelis seabelis added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Type: Question This issue doesn't require code. A question needs an answer. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Lead labels Jan 26, 2021
@BrittanyBunk
Copy link
Contributor

BrittanyBunk commented Feb 1, 2021 •
edited

duplicate of #3248.

@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Feb 17, 2021
@seabelis
Copy link
Collaborator Author

seabelis commented Mar 2, 2021

Documented here.

openlibrary/openlibrary/macros/QueryCarousel.html

Line 1 in 85bc3e6

$def with(query, title=None, sort='new', key='', limit=20, search=False, has_fulltext_only=True, url=None)

@seabelis seabelis closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Question This issue doesn't require code. A question needs an answer. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mekarpeles @seabelis @BrittanyBunk