Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instagram/Whatsapp for Sharing #4578

Closed
dwaipayan05 opened this issue Feb 12, 2021 · 4 comments · Fixed by #6469
Closed

Add Instagram/Whatsapp for Sharing #4578

dwaipayan05 opened this issue Feb 12, 2021 · 4 comments · Fixed by #6469
Assignees
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed]

Comments

@dwaipayan05
Copy link
Contributor

dwaipayan05 commented Feb 12, 2021

Among the other Social Media links for sharing, can WhatsApp/Instagram be added as the crowd over there consists of a good number of book lovers.

Describe the problem that you'd like solved

A Social Media Icon of Instagram/WhatsApp to be added in SocialShare.html which would allow the user to share the book through these. The image below is what the current social share window looks like.

image

@dwaipayan05 dwaipayan05 added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Feb 12, 2021
@mekarpeles mekarpeles added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Feb 17, 2021
@mekarpeles
Copy link
Member

@dwaipayan05 we'd be open to Facebook, Twitter, and then a More icon which uses the details tag (see the Vendors "more") to list additional share options

@jdlrobson
Copy link
Collaborator

Please consider using https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share and supporting whatever the user has installed on their phone and replacing these icons with a single unbiased-towards-a-single-platform share button.

@dbouris
Copy link
Contributor

dbouris commented Apr 10, 2022

hi @cdrini me and my colleague @Philippos01 are interested in taking over this issue, both for Whatsapp and Instagram. Do you mind assigning it to us? We have also considered using the Web Share API as @jdlrobson mentioned above

@cdrini cdrini added Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels Apr 11, 2022
@cdrini
Copy link
Collaborator

cdrini commented Apr 11, 2022

Notes from discussion:

  • Replace 4 share icons with single “[ICON] Share” button + modal
  • Investigate where to integrate web share api; should just be one option in the modal?
  • Need to keep “Embed” as an option – that’s our currently most clicked share button
  • TODO: jimchamp get share icon to use

Seems like a good one @dbouris ! @jimchamp will help answer any questions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed]
Projects
Status: Done
5 participants