Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Search Inside Results Page Interactive Elements for Accessibility #4905

Open
bpmcneilly opened this issue Mar 26, 2021 · 3 comments
Open
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Accessibility Work related to disability accessibility. [managed]

Comments

@bpmcneilly
Copy link
Contributor

Page to Test:

Search Inside Results - https://openlibrary.org/search/inside?q=The+Crucible&mode=ebooks&has_fulltext=true

Steps

Steps for this task are outlined in #4897

Expectations

Test the specified page according to the steps outlined in the parent issue. Create individual bugs with steps to reproduce for any found violations on this page. Reference those bugs on this tracking issue.

Once the page has been tested & all bugs are found, close this issue.

@bpmcneilly bpmcneilly added Theme: Accessibility Work related to disability accessibility. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] labels Mar 26, 2021
@bpmcneilly bpmcneilly added this to To Do in Accessibility via automation Mar 26, 2021
@Yashs911
Copy link
Contributor

@bpmcneilly I would like to work on this issue

@Yashs911
Copy link
Contributor

  1. When the user tab through both Search Inside and Search Result Page it opens the search-dropdown and it can not be collapsed so my suggestion was as we already have the input in a second search bar we can just remove the input from the top search bar.
  2. Also need the focus outline for bookcovers
    image

@cdrini cdrini added the Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] label Feb 7, 2022
@tuminzee
Copy link
Collaborator

@Yashs911 would you still be interested in working on this issue?

@mekarpeles mekarpeles added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Accessibility Work related to disability accessibility. [managed]
Projects
Development

No branches or pull requests

5 participants