Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Help Page Interactive Elements for Accessibility #4907

Open
bpmcneilly opened this issue Mar 26, 2021 · 4 comments
Open

Test Help Page Interactive Elements for Accessibility #4907

bpmcneilly opened this issue Mar 26, 2021 · 4 comments
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Accessibility Work related to disability accessibility. [managed]

Comments

@bpmcneilly
Copy link
Contributor

Page to Test:

Help Page - https://openlibrary.org/help/faq/about

Steps

Steps for this task are outlined in #4897

Expectations

Test the specified page according to the steps outlined in the parent issue. Create individual bugs with steps to reproduce for any found violations on this page. Reference those bugs on this tracking issue.

Once the page has been tested & all bugs are found, close this issue.

@bpmcneilly bpmcneilly added Theme: Accessibility Work related to disability accessibility. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] labels Mar 26, 2021
@bpmcneilly bpmcneilly added this to To Do in Accessibility via automation Mar 26, 2021
@ArunTeltia
Copy link
Contributor

I tested every element in the https://openlibrary.org/help/faq/about page ,every element is keyboard accessible
Tested by going from top to bottom and bottom to top.

There is one problem with the keyboard accessibility that I can think is the radio buttons are not accessible by keyboard this is the same issue over and over again,
In the /help/faq/about page when worked on the history of the page
The link to the histoy : https://openlibrary.org/help/faq/about?v=1&m=history

Here radio buttons are not accessible

@bpmcneilly
Copy link
Contributor Author

Hey @ArunTeltia - thanks for checking this page! I can see what you mean about the radio buttons. Currently these are working as we'd expect from a set of radio buttons coded this way, but the exact use case is definitely unique & the interaction via the keyboard isn't intuitive.

If you want to tackle this issue, feel free to create one & start working on it! Looking at the radio buttons, one thing we'll definitely need to do is look at updating their accessible names - right now the title attribute is making each radio button have the same name (either "Compare this version..." or "...to this version". Because of the structure, we may need to use aria-labelledby attributes.

If you have other issues on your plate (I know you were working on the nav bar stuff) let me know & I'll create the issue myself & we can find someone to work on it!

@ArunTeltia
Copy link
Contributor

Definately I will like to work on this
For the record I researched and got to know that we can also make radiobuttons keyboard accessible by some css work if I remeber correctly if that will be alright I would want to work on it

@bpmcneilly bpmcneilly removed the Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] label Mar 30, 2021
@cdrini cdrini added the Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] label Feb 7, 2022
@tuminzee
Copy link
Collaborator

@ArunTeltia are you still working on this issue?

@tuminzee tuminzee added the Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] label Feb 26, 2022
@mekarpeles mekarpeles added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Accessibility Work related to disability accessibility. [managed]
Projects
Development

No branches or pull requests

5 participants