Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibraryThingidentifiers are for works, not editions #497

Open
Tracked by #8271
LeadSongDog opened this issue May 23, 2017 · 3 comments
Open
Tracked by #8271

LibraryThingidentifiers are for works, not editions #497

LeadSongDog opened this issue May 23, 2017 · 3 comments
Labels
Affects: Data Issues that affect book/author metadata or user/account data. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] metadata Module: Merging Record merging Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Bug Something isn't working. [managed]
Projects

Comments

@LeadSongDog
Copy link

At present they are improperly attached to individual OL edition records. They should be moved, as they apply equally to all editions of a work. This could be used to help deduplicate and merge OL work records. The LT entries may also be helpful in identifying ISBNs that have been missed for a given work.

@hornc hornc added the Module: Merging Record merging label May 24, 2017
@hornc hornc added the metadata label Sep 18, 2017
@hornc
Copy link
Collaborator

hornc commented Nov 1, 2017

There are a number of places in the code where librarything ids are associated with editions:

https://github.com/internetarchive/openlibrary/search?utf8=%E2%9C%93&q=librarything&type=

most notably in openlibrary/plugins/openlibrary/pages/config_edition.page where it is specified as an edition identifer.

Currently there are 4.3M edition records that have librarything identifiers associated at the edition level

grep -c '"librarything":' ol_dump_editions_2017-09-30.txt 
4304416

I'll do some analysis to check how many are duplicate ids..

@LeadSongDog
Copy link
Author

LeadSongDog commented Jan 10, 2018

@mekarpeles Should this also move to the client?

@xayhewalo xayhewalo added this to Un-Triaged in Triage Oct 18, 2019
@xayhewalo xayhewalo added State: Backlogged Type: Bug Something isn't working. [managed] Affects: Data Issues that affect book/author metadata or user/account data. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Oct 25, 2019
@xayhewalo
Copy link
Collaborator

This still appears to be a problem. @hornc Are you willing to be assignee for this issue? Note, being the assignee doesn't necessarily mean you are responsible for doing the work, just responsible for gathering/providing information to address the issue. From the Wiki.

The assigned owner is not necessarily the person who will fix the issue (it is not necessarily even established, at that point, if or when the issue will be fixed at all), but rather they are the person who will do as much or as little as needed to handle the issue (asking questions, soliciting input, establishing and updating the priority, checking if it is a duplicate, etc).

Once an issue is labeled State: Work In Progress, the owner is the individual doing the work, or leading/coordinating the group that is doing the work.

I've added labels per context: let me know your thoughts

@xayhewalo xayhewalo moved this from Un-Triaged to Needs: Assessment in Triage Oct 25, 2019
@xayhewalo xayhewalo added Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] labels Nov 26, 2019
@cdrini cdrini added Needs: Lead Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Data Issues that affect book/author metadata or user/account data. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] metadata Module: Merging Record merging Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Bug Something isn't working. [managed]
Projects
No open projects
Triage
  
Needs: Assessment
Development

No branches or pull requests

4 participants