Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search API requests for "readable ebooks only" may also return unreadable books. #4995

Open
waldenn opened this issue Apr 7, 2021 · 2 comments
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]

Comments

@waldenn
Copy link

waldenn commented Apr 7, 2021

Search API requests for "readable ebooks only" may also return unreadable books.

Evidence / Screenshot (if possible)

Example 1:

Example 2:

Proposal & Constraints

The record data of the items seems wrong, but the web-frontend is able to detect that these books are not-readable.
Remove the not-readable ebook results from the API-results, in the same way this is detected for the web interface (not sure how that is done currently).

@waldenn waldenn added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Apr 7, 2021
@waldenn waldenn changed the title Search API requests for "readable ebooks only" also returns some unreadable books. Search API requests for "readable ebooks only" may also return unreadable books. Apr 7, 2021
@mekarpeles
Copy link
Member

This is happening because some books are print-disabled only (i.e. only available to print disabled patrons).

I believe you'd like the search API to only return works which have borrowable or readable copies and this is not something we can easily do without completely changing how we index works and editions and their availability within solr.

@mekarpeles mekarpeles added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Search Issues related to search UI and backend. [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Apr 12, 2021
@waldenn
Copy link
Author

waldenn commented Apr 12, 2021

Yes. Ok, thanks for the info.

What about adding a "text"-field string to indicate a "disabled-print-only" book? Then one could just filter these books out of the results on client side. The total results would not be correct with the displayed results, but that's a minor issue that could be worked around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

2 participants