Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI lacks a way to correct author links from edition records #5265

Open
LeadSongDog opened this issue Jun 3, 2021 · 1 comment
Open

UI lacks a way to correct author links from edition records #5265

LeadSongDog opened this issue Jun 3, 2021 · 1 comment
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @seabelis Issuses overseen by Lisa (Staff: Lead Community Librarian) [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]

Comments

@LeadSongDog
Copy link

The UI permits author link corrections on work records only. Correcting those links fails to correct the corresponding link on editions, so those editions remain nonsensically linked to the wrong author record and appear as such in solr indexing. This makes author disambiguation fruitless.

Evidence / Screenshot (if possible)

Discussed at #2625

Changing Austin to Jon W Austin here:
https://openlibrary.org/books/OL13377550M/Heart_and_Lung_Machine_and_Related_Technologies_of_Open_Heart_Surgery?_compare=Compare&b=2&a=1&m=diff

leaves https://openlibrary.org/works/OL24560932W.json
and https://openlibrary.org/books/OL13377550M.json
with different author linkages when they should agree.

Relevant url?

Steps to Reproduce

  1. Go to ...
  2. Do ...
  • Actual:
  • Expected:

Details

  • Logged in (Y/N)? y
  • Browser type/version? any
  • Operating system? any
  • Environment (prod/dev/local)? prod

Proposal & Constraints

  1. When work record’s author link changes from OL1A to OL2A, either
    a)make the same change on every edition record or
    b)simply remove OL1A from edition records.
  2. On the edition edit page, add a boxed-x delete widget beside each displayed author
  3. Hilight or links that differ between work and edition records

Related files

Stakeholders

@LeadSongDog LeadSongDog added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Jun 3, 2021
@LeadSongDog LeadSongDog changed the title UI lacks a way to delete incorrect author links from edition records UI lacks a way to correct author links from edition records Jun 3, 2021
@mekarpeles mekarpeles added Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @seabelis Issuses overseen by Lisa (Staff: Lead Community Librarian) [managed] and removed Needs: Lead labels Jun 7, 2021
@LeadSongDog
Copy link
Author

Before fixing a wrong author on an edition, it will be necessary to know it is wrong. Right now those edition author IDs are buried in the json, not exposed to a user’s awareness. It would help if author IDs for an edition that differ from those for the work could be highlighted in the UI. Then we can talk about tools for fixing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @seabelis Issuses overseen by Lisa (Staff: Lead Community Librarian) [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

2 participants