Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two new identifiers #5275

Closed
FinixFighter opened this issue Jun 6, 2021 · 5 comments
Closed

Adding two new identifiers #5275

FinixFighter opened this issue Jun 6, 2021 · 5 comments
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed]

Comments

@FinixFighter
Copy link

Hi! I found two databases which are very useful and contain a lot of information about comic books. These two are the Grand Comics Database https://www.comics.org/ and I.N.D.U.C.K.S https://inducks.org/.

I think it would be good to add them to the list of identifiers, so that we can also add the respective ID numbers other than ISBN, Google, Amazon, etc...
These two database (INDUCKS in particular) contain tons of information about comic books, so that if someone wants more information about that book, he/she can easily see it just by one click.

Once we can add GCD and INDUCKS identifiers, we might even think about creating a bot for adding/updating books from those sources.

@FinixFighter FinixFighter added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jun 6, 2021
@RayBB
Copy link
Collaborator

RayBB commented Jun 7, 2021

For anyone looking to do this you'll probably have to edit the config as mentioned here #5093 (comment) (https://openlibrary.org/config/edition)

@mekarpeles mekarpeles added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jun 7, 2021
@cdrini
Copy link
Collaborator

cdrini commented Jun 7, 2021

Sounds good! Easy to add; I need information in this format. Is there a pattern to the URLs (note the @@@)? That way we can correctly link to them in the UI :)

    label: W. W. Norton
    name: w._w._norton
    notes:
    url: http://books.wwnorton.com/books/detail.aspx?ID=@@@
    website: http://wwnorton.com

@FinixFighter
Copy link
Author

Sounds good! Easy to add; I need information in this format. Is there a pattern to the URLs (note the @@@)? That way we can correctly link to them in the UI :)

    label: W. W. Norton
    name: w._w._norton
    notes:
    url: http://books.wwnorton.com/books/detail.aspx?ID=@@@
    website: http://wwnorton.com

For Grand Comics Database the url is url: https://www.comics.org/issue/@@@
Example: https://www.comics.org/issue/1642084/

For INDUCKS it is: https://inducks.org/issue.php?c=@@@
Examples:
-https://inducks.org/issue.php?c=br%2FPDCL++++1
-https://inducks.org/issue.php?c=it%2FTL+3412
-https://inducks.org/issue.php?c=cn%2FMC2001-19

@cdrini
Copy link
Collaborator

cdrini commented Jun 8, 2021

Ok! Should be there now :) Let me know if they're not working as expected!

@cdrini cdrini closed this as completed Jun 8, 2021
@cdrini cdrini self-assigned this Jun 8, 2021
@FinixFighter
Copy link
Author

Ok! Should be there now :) Let me know if they're not working as expected!

It works! Thank you very much!
Here's an example: https://openlibrary.org/books/OL32014771M/Zio_Paperone_Co_La_Dinastia_dei_Paperi
Have a nice day! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed]
Projects
None yet
Development

No branches or pull requests

4 participants