Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://openlibrary.org/authors/OL41A/works.json retuns a non json response when author not found #5488

Open
RayBB opened this issue Aug 2, 2021 · 0 comments
Open

https://openlibrary.org/authors/OL41A/works.json retuns a non json response when author not found #5488

RayBB opened this issue Aug 2, 2021 · 0 comments
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Aug 2, 2021 •
edited

As I've been learning the API and working with it. I found that when looking at author works it returns an html page instead of json error when an author is not found.

Evidence / Screenshot (if possible)

image

Relevant url?

https://openlibrary.org/authors/OL41A/works.json

Steps to Reproduce

  1. Go to the url

Details

  • Logged in (Y/N)? N
  • Browser type/version? FF
  • Operating system? Mac
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Ah seems related to #3718

Related files

Stakeholders
@RayBB RayBB added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Aug 2, 2021
@mekarpeles mekarpeles added Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Needs: Lead labels Aug 2, 2021
@RayBB RayBB mentioned this issue Aug 5, 2021
Closed
@mekarpeles mekarpeles added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RayBB @mekarpeles